Skip to content

move landing page to framer #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

move landing page to framer #5146

merged 1 commit into from
Oct 24, 2024

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Oct 23, 2024 •
edited by pr-codex bot
Loading

TL;DR

Removed homepage components and related code from the dashboard app.

What changed?

  • Deleted several homepage-related components and sections
  • Removed homepage route and associated page component
  • Eliminated unused imports and dependencies
  • Deleted partner carousel and metrics data
  • Removed homepage-specific styling and layout components

How to test?

  1. Verify that the homepage route (/) no longer renders the previous content
  2. Ensure that removed components are not referenced elsewhere in the app
  3. Check that the build process completes successfully without errors related to missing components

Why make this change?

This change appears to be part of a larger effort to streamline the dashboard app by removing the dedicated homepage. It likely aims to simplify the codebase, reduce maintenance overhead, and potentially shift focus to core dashboard functionality rather than marketing-oriented content.

PR-Codex overview

This PR primarily focuses on removing several components and pages from the apps/dashboard directory, updating the framer-rewrites configuration, and modifying some settings in next.config.js to streamline the application.

Detailed summary

  • Deleted multiple components and pages in apps/dashboard/src.
  • Added paths to framer-rewrites.js.
  • Updated next-sitemap.config.js to include FRAMER_PATHS.
  • Modified next.config.js to require FRAMER_PATHS from framer-rewrites.
  • Changed silent option in next.config.js from false to true.
  • Removed the metrics export from apps/dashboard/src/components/product-pages/common/nav/data.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:57pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:57pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:57pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:57pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b826adf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 23, 2024
@jnsdls jnsdls marked this pull request as ready for review October 23, 2024 22:15
@codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (3cf0039) to head (b826adf).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5146      +/-   ##
==========================================
+ Coverage   45.43%   45.45%   +0.02%     
==========================================
  Files        1066     1065       -1     
  Lines       55150    55122      -28     
  Branches     3974     3975       +1     
==========================================
- Hits        25055    25054       -1     
+ Misses      29403    29376      -27     
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3cf0039
packages 40.47% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 23, 2024 — with Graphite App
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 6 s (+78.5% 🔺) 6.8 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 7.7 s (+5.95% 🔺) 9.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 202 ms (-31.54% 🔽) 299 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 219 ms (+230.29% 🔺) 229 ms
thirdweb/react (minimal + tree-shaking) 17.33 KB (0%) 347 ms (0%) 591 ms (-1.79% 🔽) 937 ms

@jnsdls jnsdls force-pushed the 10-23-move_landing_page_to_framer branch from 41e8b9c to 3c128e4 Compare October 23, 2024 23:23
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@jnsdls jnsdls removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 23, 2024
@jnsdls jnsdls force-pushed the 10-23-move_landing_page_to_framer branch from 3c128e4 to b826adf Compare October 23, 2024 23:47
@jnsdls jnsdls merged commit e6e9944 into main Oct 24, 2024
31 checks passed
@jnsdls jnsdls deleted the 10-23-move_landing_page_to_framer branch October 24, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank Awaiting requested review from MananTank

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnsdls